[webkit-reviews] review granted: [Bug 182408] Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies : [Attachment 332915] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 182408: Improve NetworkResourceLogger to report blocked (versus
non-partitioned) cookies
https://bugs.webkit.org/show_bug.cgi?id=182408

Attachment 332915: Patch

https://bugs.webkit.org/attachment.cgi?id=332915&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332915
  --> https://bugs.webkit.org/attachment.cgi?id=332915
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>      auto networkStorageSession =
WebCore::NetworkStorageSession::storageSession(sessionID());

Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning
of this method?

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
> +	   s.replace('\\', "\\\\").replace('"', "\\\"");

return s.replace('\\', "\\\\").replace('"', "\\\"");