[webkit-reviews] review denied: [Bug 179622] Web Inspector: Styles Redesign: Pasting multiple properties should create properties instead of a bad property : [Attachment 332463] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 1 15:06:22 PST 2018


Matt Baker <mattbaker at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 179622: Web Inspector: Styles Redesign: Pasting multiple properties should
create properties instead of a bad property
https://bugs.webkit.org/show_bug.cgi?id=179622

Attachment 332463: Patch

https://bugs.webkit.org/attachment.cgi?id=332463&action=review




--- Comment #12 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 332463
  --> https://bugs.webkit.org/attachment.cgi?id=332463
Patch

r- for the following:

Pasting multiple commented properties doesn't work, and leaves the Style {} UI
in an unusable state.

Paste `/*color: red; margin: 0;*/` in the blank property created after clicking
in the Style {} UI.

Expected:
Style {
    [ ] /* color: red; */
    [ ] /* margin: 0; */
    [ ] _
}

Actual:
Style {
}

The Style {} UI is blank, and clicking inside it no longer creates a new blank
property.


More information about the webkit-reviews mailing list