[webkit-reviews] review granted: [Bug 182404] Fix crashes due to mishandling custom sections. : [Attachment 332906] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 1 14:12:29 PST 2018

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 182404: Fix crashes due to mishandling custom sections.

Attachment 332906: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 332906
  --> https://bugs.webkit.org/attachment.cgi?id=332906

View in context: https://bugs.webkit.org/attachment.cgi?id=332906&action=review


> Source/JavaScriptCore/wasm/WasmModuleParser.cpp:58
> +    // This is  not really a known section

extra space

> Source/JavaScriptCore/wasm/WasmSections.h:55
> +    // It's important that Begin is less than every other section number and
that Custom is greater.
> +    // This only works because section numbers are currently monotonically
increasing and we don't support
> +    // any custom sections. Also, Begin is not a real section but is used as
a marker for validating the ordering
> +    // of sections.
> +    Begin = 0,

static_assert please

More information about the webkit-reviews mailing list