[webkit-reviews] review granted: [Bug 182301] Delay service worker process creation until actually needed by SWServer : [Attachment 332901] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 182301: Delay service worker process creation until actually needed by
SWServer
https://bugs.webkit.org/show_bug.cgi?id=182301

Attachment 332901: Patch

https://bugs.webkit.org/attachment.cgi?id=332901&action=review




--- Comment #14 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 332901
  --> https://bugs.webkit.org/attachment.cgi?id=332901
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332901&action=review

r=me with comment.

> Source/WebCore/workers/service/server/SWServer.cpp:219
> +void SWServer::Connection::scheduleJob(ServiceWorkerJobData&& jobData)

I do not think we need this method on SWServer::Connection.

> Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp:210
> +    scheduleJob(WTFMove(jobData));

we can call server().scheduleJob(WTFMove(jobData)); directly, like we do in the
other methods. No needs for a scheduleJob on Connection.