[webkit-reviews] review canceled: [Bug 182370] Fix race-condition in fast/forms/ios/ipad/select-form-run-twice.html : [Attachment 332830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 1 09:10:26 PST 2018

Jonathan Bedard <jbedard at apple.com> has canceled Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 182370: Fix race-condition in

Attachment 332830: Patch


--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 332830
  --> https://bugs.webkit.org/attachment.cgi?id=332830

View in context: https://bugs.webkit.org/attachment.cgi?id=332830&action=review

>> LayoutTests/fast/forms/ios/ipad/select-form-run-twice.html:37
>> +		Promise.all(promises).then(function() {
> `promises` is empty when we Promise.all here, so wouldn't this just resolve
on the next runloop?

For some reason I had thought that the other js functions had run already, but
you are correct. I'll re-work this change.

More information about the webkit-reviews mailing list