[webkit-reviews] review granted: [Bug 193029] [Win][Clang] Fix compilation warnings of MiniBrowser : [Attachment 358095] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 193029: [Win][Clang] Fix compilation warnings of MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=193029

Attachment 358095: Patch

https://bugs.webkit.org/attachment.cgi?id=358095&action=review




--- Comment #8 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 358095
  --> https://bugs.webkit.org/attachment.cgi?id=358095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358095&action=review

r=me with a final question.

> Tools/MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:619
> -static void initDocStruct(DOCINFO* di, TCHAR* docname)
> +static void initDocStruct(DOCINFO* di, const wchar_t* docname)
>  {
>      memset(di, 0, sizeof(DOCINFO));
>      di->cbSize = sizeof(DOCINFO);
> -    di->lpszDocName = docname;
> +    di->lpszDocName = const_cast<wchar_t*>(docname);

According to MSDN, it seems that lpszDocName should be LPCSTR:
https://docs.microsoft.com/en-us/windows/desktop/api/wingdi/ns-wingdi-_docinfoa

If so, isn't it okay for docname to be const?