[webkit-reviews] review granted: [Bug 192658] Resurrect Mac CMake build : [Attachment 357847] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 26 16:04:05 PST 2018


Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 192658: Resurrect Mac CMake build
https://bugs.webkit.org/show_bug.cgi?id=192658

Attachment 357847: Patch

https://bugs.webkit.org/attachment.cgi?id=357847&action=review




--- Comment #13 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 357847
  --> https://bugs.webkit.org/attachment.cgi?id=357847
Patch

OK, r=me as Alex described this is a first step to resurrect macOS CMake build.
CMake build can offer various fancy tools. For example, compile_commands.json
can be generated, and it can be an input of many fancy tools (e.g. clang-tidy).
CMake ports are useful and thus I think it is worth resurrecting.


More information about the webkit-reviews mailing list