[webkit-reviews] review denied: [Bug 178489] Web Inspector: Styles Redesign: Editing selector should not hide the rule : [Attachment 356749] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 178489: Web Inspector: Styles Redesign: Editing selector should not hide
the rule
https://bugs.webkit.org/show_bug.cgi?id=178489

Attachment 356749: Patch

https://bugs.webkit.org/attachment.cgi?id=356749&action=review




--- Comment #15 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 356749
  --> https://bugs.webkit.org/attachment.cgi?id=356749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356749&action=review

Seems to work, but It's hard to tell which changes are essential to fixing the
problem. Could you drop the unnecessary refactoring and add a change log
comment or two? Doesn't have to be long, just a sentence or two explaining the
approach you took.

> Source/WebInspectorUI/UserInterface/Models/CSSRule.js:59
> +    update(sourceCodeLocation, selectorText, selectors,
matchedSelectorIndices, style, mediaList)

Why was the flag dropped?