[webkit-reviews] review granted: [Bug 192970] [curl] Move cookiePersistentStorageFile from NetworkProcessCreationParameters to NetworkSessionCreationParameters : [Attachment 357921] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 21 09:44:38 PST 2018
Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192970: [curl] Move cookiePersistentStorageFile from
NetworkProcessCreationParameters to NetworkSessionCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192970
Attachment 357921: Patch
https://bugs.webkit.org/attachment.cgi?id=357921&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 357921
--> https://bugs.webkit.org/attachment.cgi?id=357921
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357921&action=review
r=me. Thanks
> Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:43
> +
NetworkProcess::singleton().supplement<WebCookieManager>()->setCookiePersistent
Storage(parameters.cookiePersistentStorageFile);
This is a great step in the right direction. Thanks! The next step would be
to stop using the NetworkProcess::singleton() for this.
More information about the webkit-reviews
mailing list