[webkit-reviews] review granted: [Bug 192859] REGRESSION(r239353): iOS WK1 Assertion failure in notifyChildNodeRemoved while running TestWebKitAPI.QuickLook.LegacyQuickLookContent : [Attachment 357927] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 21 06:41:54 PST 2018


Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 192859: REGRESSION(r239353): iOS WK1 Assertion failure in
notifyChildNodeRemoved while running
TestWebKitAPI.QuickLook.LegacyQuickLookContent
https://bugs.webkit.org/show_bug.cgi?id=192859

Attachment 357927: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=357927&action=review




--- Comment #7 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 357927
  --> https://bugs.webkit.org/attachment.cgi?id=357927
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=357927&action=review

> Source/WebCore/dom/ScriptDisallowedScope.h:90
> +	   static bool hasDisallowedScope() { return s_count; }

Could we still ASSERT(isMainThread())?


More information about the webkit-reviews mailing list