[webkit-reviews] review granted: [Bug 192905] Add support to run-benchmark to use non-default copies of the browser apps : [Attachment 357883] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 192905: Add support to run-benchmark to use non-default copies of the
browser apps
https://bugs.webkit.org/show_bug.cgi?id=192905

Attachment 357883: Patch

https://bugs.webkit.org/attachment.cgi?id=357883&action=review




--- Comment #11 from dewei_zhu at apple.com ---
Comment on attachment 357883
  --> https://bugs.webkit.org/attachment.cgi?id=357883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357883&action=review

> Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:49
> +
> +    group = parser.add_mutually_exclusive_group()
> +    group.add_argument('--browser-path', help='Specify the path to a
non-default copy of the target browser as a path to the .app.')
> +    group.add_argument('--build-directory', dest='build_dir', help='Path to
the browser executable (e.g. WebKitBuild/Release/).')
> +

Nit: It seems cleaner if we move this section below the last time we invoke
parser.add_argument.