[webkit-reviews] review requested: [Bug 192945] Use unorm2_normalize instead of precomposedStringWithCanonicalMapping in userVisibleString : [Attachment 357865] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has asked  for review:
Bug 192945: Use unorm2_normalize instead of
precomposedStringWithCanonicalMapping in userVisibleString
https://bugs.webkit.org/show_bug.cgi?id=192945

Attachment 357865: Patch

https://bugs.webkit.org/attachment.cgi?id=357865&action=review




--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 357865
  --> https://bugs.webkit.org/attachment.cgi?id=357865
Patch

OK, all the bots are happy except for the network error....

This is my first Objective C[++] ever and I am very proud of it! Even if it is
mostly copied from Ms2ger.

Note that after this lands, I will immediately reland the patch in bug #174816,
deleting all this code. This commit is just to make sure that if the switch
from the NSString normalization to the ICU normalization introduces an
unexpected regression, it will bisect down to this small revision instead of
the huge patch in that bug.