[webkit-reviews] review granted: [Bug 192916] Web Inspector: Dark Mode: Type profiler popovers have black text on dark background : [Attachment 357859] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 192916: Web Inspector: Dark Mode: Type profiler popovers have black text on
dark background
https://bugs.webkit.org/show_bug.cgi?id=192916

Attachment 357859: Patch

https://bugs.webkit.org/attachment.cgi?id=357859&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357859
  --> https://bugs.webkit.org/attachment.cgi?id=357859
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357859&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css:147
> -    border-top: 1px solid hsla(0, 0%, 0%, 0.3);
> +    border-top: 1px solid var(--text-color-quaternary);

Not sure how much this matters, but these two colors are different in light
mode (`hsla(0, 0%, 0%, 0.3)` vs `hsl(0, 0%, 33%)`).

> Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css:79
> +

Style: remove the extra newlines for this rule.