[webkit-reviews] review denied: [Bug 192956] [WebGPU] Convert WebGPUBindGroups into MTLArgumentEncoders : [Attachment 357887] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 20 16:10:46 PST 2018
Myles C. Maxfield <mmaxfield at apple.com> has denied Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 192956: [WebGPU] Convert WebGPUBindGroups into MTLArgumentEncoders
https://bugs.webkit.org/show_bug.cgi?id=192956
Attachment 357887: Patch
https://bugs.webkit.org/attachment.cgi?id=357887&action=review
--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 357887
--> https://bugs.webkit.org/attachment.cgi?id=357887
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357887&action=review
> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:57
> + map.set(stage, [[NSMutableArray alloc]
initWithObjects:argument.get(), nil]);
HashMaps require that their keys not be 0
> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:91
> + auto mtlArgumentEncoder = adoptNS([device.platformDevice()
newArgumentEncoderWithArguments:argumentArrayPair.value.get()]);
I think this will fail if there are 0 items in the array. I suggest you filter
those out.
More information about the webkit-reviews
mailing list