[webkit-reviews] review granted: [Bug 192937] Move HTTPS_UPGRADE code behind a runtime flag, off by default : [Attachment 357841] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 15:50:00 PST 2018

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 192937: Move HTTPS_UPGRADE code behind a runtime flag, off by default

Attachment 357841: Patch


--- Comment #17 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 357841
  --> https://bugs.webkit.org/attachment.cgi?id=357841

View in context: https://bugs.webkit.org/attachment.cgi?id=357841&action=review

> Source/WebKit/NetworkProcess/PingLoad.cpp:46
> +    , m_networkLoadChecker(makeUniqueRef<NetworkLoadChecker>(FetchOptions {
m_parameters.options}, m_parameters.sessionID, m_parameters.webPageID,
m_parameters.webFrameID, WTFMove(m_parameters.originalRequestHeaders), URL {
m_parameters.request.url() }, m_parameters.sourceOrigin.copyRef(),
m_parameters.preflightPolicy, false, m_parameters.request.httpReferrer()))

Not very clear what false means here.
Maybe isHTTPSUpgradeEnabled should be the last parameter and set to false by
default, like requestLoadType.

More information about the webkit-reviews mailing list