[webkit-reviews] review denied: [Bug 192943] Moving non-critical initializations to a parallel thread can speed up process launch time by 15%. : [Attachment 357845] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Suresh Koppisetty
<skoppisetty at apple.com>'s request for review:
Bug 192943: Moving non-critical initializations to a parallel thread can speed
up process launch time by 15%.
https://bugs.webkit.org/show_bug.cgi?id=192943

Attachment 357845: Patch

https://bugs.webkit.org/attachment.cgi?id=357845&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357845
  --> https://bugs.webkit.org/attachment.cgi?id=357845
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357845&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:368
> +    dispatch_async(m_internalQueue, ^{

WebProcess::updateProcessName() would have to use the same (serial) queue,
otherwise, the call to _RegisterApplication() may happen *after* we've tried to
set the process name and setting the process name would fail.