[webkit-reviews] review granted: [Bug 192918] Web Inspector: Audits: don't cache default audits : [Attachment 357788] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 20 00:06:01 PST 2018


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 192918: Web Inspector: Audits: don't cache default audits
https://bugs.webkit.org/show_bug.cgi?id=192918

Attachment 357788: Patch

https://bugs.webkit.org/attachment.cgi?id=357788&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 357788
  --> https://bugs.webkit.org/attachment.cgi?id=357788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357788&action=review

r=me

> Source/WebInspectorUI/ChangeLog:9
> +	   * UserInterface/Controllers/AuditManager.js:

Needs a changelog. For example, explain that by caching you mean using
IndexedDB to save the audits. If default audits are not stored in IDB, they
will be programmatically recreated every time with UIString labels looked up at
runtime using the current locale.


More information about the webkit-reviews mailing list