[webkit-reviews] review granted: [Bug 153962] Web Inspector: WebInspector.UIString should take an optional key and description to aid localization : [Attachment 357786] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 153962: Web Inspector: WebInspector.UIString should take an optional key
and description to aid localization
https://bugs.webkit.org/show_bug.cgi?id=153962

Attachment 357786: Patch

https://bugs.webkit.org/attachment.cgi?id=357786&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 357786
  --> https://bugs.webkit.org/attachment.cgi?id=357786
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357786&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js:68
> +	   const format = WI.UIString("%s%%", "audit-percentage-pass", "The
number of tests that passed expressed as a percentage, followed by a literal
%.");

Let's follow existing practice in Safari and use human-readable keys. In this
case, something like "Percentage (of audits)". Ideally we wouldn't have a
percent UIString floating by itself since it may interact with surrounding
text, but I don't think it's a real problem in this specific instance.