[webkit-reviews] review granted: [Bug 192910] ITMLKit Inspector: Elements tab does not show DOM Tree : [Attachment 357770] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 192910: ITMLKit Inspector: Elements tab does not show DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=192910

Attachment 357770: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=357770&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 357770
  --> https://bugs.webkit.org/attachment.cgi?id=357770
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=357770&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:764
> +	   if (WI.mainTarget.DOMAgent)

I was a little puzzled seeing these additions. Were these things simply not
being done before, or did they move after target multiplexing was added?

> Source/WebInspectorUI/UserInterface/Protocol/Connection.js:180
> +	       console.error("Protocol Error: Attempted to dispatch an
unspecified method '" + qualifiedName + "'", messageObject);

Nice tweak.