[webkit-reviews] review denied: [Bug 153962] Web Inspector: WebInspector.UIString should take an optional key and description to aid localization : [Attachment 357764] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 153962: Web Inspector: WebInspector.UIString should take an optional key
and description to aid localization
https://bugs.webkit.org/show_bug.cgi?id=153962

Attachment 357764: Patch

https://bugs.webkit.org/attachment.cgi?id=357764&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 357764
  --> https://bugs.webkit.org/attachment.cgi?id=357764
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357764&action=review

It would be nice if you could add a single usage of each form that we expect to
work into the codebase, so that the script can be shown to work correctly.

> Tools/Scripts/extract-localizable-js-strings:-78
> -	   print "$file:$.:WARNING: $&\n" while s/WI\.UIString\(.*?\)//;

Why did this warning get removed? It seems useful in the case where the
arguments to UIString could not be parsed.

> Tools/Scripts/extract-localizable-js-strings:154
> +    $localizedStrings .= " // $commentByKey{$key}" if length
$commentByKey{$key};

To make this consistent with Cocoa lproj files, please make the following
changes:
- the comment should precede the localized string
- use /* multiline comment style */