[webkit-reviews] review requested: [Bug 192897] [iOS] Interpret text key commands on keydown and app key commands on keypress : [Attachment 357755] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 19 16:51:27 PST 2018
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 192897: [iOS] Interpret text key commands on keydown and app key commands
on keypress
https://bugs.webkit.org/show_bug.cgi?id=192897
Attachment 357755: Patch
https://bugs.webkit.org/attachment.cgi?id=357755&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 357755
--> https://bugs.webkit.org/attachment.cgi?id=357755&action=review
Patch
I did not include a test for this change since we need to fix bug #192898 in
order to support testing Control-modified key commands. Will upload a test that
we can use once bug #192898 is fixed. We no longer need to check that we are
interpreting a keydown event before calling the SPI as the SPI does this check
for us.
More information about the webkit-reviews
mailing list