[webkit-reviews] review granted: [Bug 192676] Navigations away from the SafeBrowsing interstitial show a flash of old content : [Attachment 357742] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 192676: Navigations away from the SafeBrowsing interstitial show a flash of
old content
https://bugs.webkit.org/show_bug.cgi?id=192676

Attachment 357742: Patch

https://bugs.webkit.org/attachment.cgi?id=357742&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 357742
  --> https://bugs.webkit.org/attachment.cgi?id=357742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357742&action=review

r=me with suggestion.

> Source/WebKit/UIProcess/WebPageProxy.cpp:4199
> +	   pageClient().clearSafeBrowsingWarningIfForMainFrameNavigation();

Cannot we call clearSafeBrowsingWarningIfForMainFrameNavigation() from inside
PageClient::didFirstVisuallyNonEmptyLayoutForMainFrame()?