[webkit-reviews] review granted: [Bug 192784] Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color : [Attachment 357750] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 192784: Web Inspector: Styles: shift-clicking a color-swatch to change
formats starts editing the color
https://bugs.webkit.org/show_bug.cgi?id=192784

Attachment 357750: Patch

https://bugs.webkit.org/attachment.cgi?id=357750&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357750
  --> https://bugs.webkit.org/attachment.cgi?id=357750
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357750&action=review

rs=me, thanks for the quick fix!

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:484
> +	       if (this._swatchActive || event.shiftKey)

Is there any reason to not prevent editing when clicking on the swatch?  Is
this needed to make sure multiple-selection works with ⌘-click/⇧-click?  If
that's the case, should this check instead just be that we aren't in
"multiple-selection mode" or that "multiple-selection isn't active"?