[webkit-reviews] review granted: [Bug 192853] stringProtoFuncRepeatCharacter overflow is not caught with 16-bit character times 2**30 : [Attachment 357741] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 192853: stringProtoFuncRepeatCharacter overflow is not caught with 16-bit
character times 2**30
https://bugs.webkit.org/show_bug.cgi?id=192853

Attachment 357741: Patch

https://bugs.webkit.org/attachment.cgi?id=357741&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 357741
  --> https://bugs.webkit.org/attachment.cgi?id=357741
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357741&action=review

r=me

> Source/WTF/wtf/text/StringImpl.h:575
> +template<typename CharacterType> size_t reverseFindLineTerminator(const
CharacterType*, unsigned length, unsigned index = StringImpl::MaxLength);
> +template<typename CharacterType> size_t reverseFind(const CharacterType*,
unsigned length, CharacterType matchCharacter, unsigned index =
StringImpl::MaxLength);
> +size_t reverseFind(const UChar*, unsigned length, LChar matchCharacter,
unsigned index = StringImpl::MaxLength);
> +size_t reverseFind(const LChar*, unsigned length, UChar matchCharacter,
unsigned index = StringImpl::MaxLength);

Nit: You don't need the "StringImpl::" here