[webkit-reviews] review granted: [Bug 192871] Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element : [Attachment 357716] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 14:07:49 PST 2018


Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 192871: Web Inspector: Elements tab: arrow key after undoing a DOM node
delete selects the wrong element
https://bugs.webkit.org/show_bug.cgi?id=192871

Attachment 357716: Patch

https://bugs.webkit.org/attachment.cgi?id=357716&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357716
  --> https://bugs.webkit.org/attachment.cgi?id=357716
Patch

rs=me, nice catch :)

Is it possible for us to select the item before it's been inserted?  I'd assume
not as the indexes would get all messed up.  If so, however, we may not want to
move either value if the index is selected.


More information about the webkit-reviews mailing list