[webkit-reviews] review denied: [Bug 192793] Add a new SPI for controlling getUserMedia : [Attachment 357639] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 192793: Add a new SPI for controlling getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=192793

Attachment 357639: Patch

https://bugs.webkit.org/attachment.cgi?id=357639&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 357639
  --> https://bugs.webkit.org/attachment.cgi?id=357639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357639&action=review

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:862
>      auto decisionHandler = makeBlockPtr([protectedRequest =
makeRef(request)](BOOL authorized) {

This needs a CompletionHandlerCallChecker

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:996
> +	   auto decisionHandler = makeBlockPtr([protectedRequest =
makeRef(request)](BOOL authorized) {

ditto