[webkit-reviews] review denied: [Bug 192855] [GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag : [Attachment 357683] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 192855: [GTK][WPE] Unify TestController::platformRunUntil() and honor
condition flag
https://bugs.webkit.org/show_bug.cgi?id=192855

Attachment 357683: Patch

https://bugs.webkit.org/attachment.cgi?id=357683&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 357683
  --> https://bugs.webkit.org/attachment.cgi?id=357683
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357683&action=review

> Tools/WebKitTestRunner/wpe/TestControllerWPE.cpp:77
> +    while (!done)
> +	   RunLoop::main().run();

This isn't right because now the timeout is no longer respected at all; it can
run forever if the job never completes.