[webkit-reviews] review granted: [Bug 192735] Allow clients to set the navigator platform : [Attachment 357646] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 19 11:36:39 PST 2018

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 192735: Allow clients to set the navigator platform

Attachment 357646: Patch


--- Comment #23 from Tim Horton <thorton at apple.com> ---
Comment on attachment 357646
  --> https://bugs.webkit.org/attachment.cgi?id=357646

View in context: https://bugs.webkit.org/attachment.cgi?id=357646&action=review

> Source/WebCore/page/Navigator.cpp:101
> +#if !OS(LINUX)

You shouldn't need this ifdef. You should just have the if !OS(LINUX) path
everywhere; now that it's on FrameLoader, it will just always be the null
String for Linux and fall back to NavigatorBase. No need for platform checks
for no reason :)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:996
> +	   [websitePolicies setCustomNavigatorPlatform:@"Test Custom

Why the 2!

More information about the webkit-reviews mailing list