[webkit-reviews] review granted: [Bug 192229] [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages : [Attachment 357229] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 192229: [GStreamer][EME][ClearKey] Request keys from CDMInstance rather
than passing via bus messages
https://bugs.webkit.org/show_bug.cgi?id=192229

Attachment 357229: Patch

https://bugs.webkit.org/attachment.cgi?id=357229&action=review




--- Comment #26 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 357229
  --> https://bugs.webkit.org/attachment.cgi?id=357229
Patch

There are some changes that you can do in follow ups, though some others like
the cdminstance ref counting and maybe the consts that IMHO should be done
here.