[webkit-reviews] review granted: [Bug 192294] [WHLSL] Add a handwritten lexer : [Attachment 357617] Patch

[bugzilla-daemon at webkit.org]

Jon Lee <jonlee at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 192294: [WHLSL] Add a handwritten lexer
https://bugs.webkit.org/show_bug.cgi?id=192294

Attachment 357617: Patch

https://bugs.webkit.org/attachment.cgi?id=357617&action=review




--- Comment #4 from Jon Lee <jonlee at apple.com> ---
Comment on attachment 357617
  --> https://bugs.webkit.org/attachment.cgi?id=357617
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357617&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp:556
> +    for ( ; m_offset < m_stringView.length() &&
!isNewline(m_stringView[m_offset]); ++m_offset) { }

Nit: consistent style of empty block.