[webkit-reviews] review granted: [Bug 192832] Error message for `-x ** y` contains a typo. : [Attachment 357623] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 18 21:12:10 PST 2018
Saam Barati <sbarati at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 192832: Error message for `-x ** y` contains a typo.
https://bugs.webkit.org/show_bug.cgi?id=192832
Attachment 357623: Patch
https://bugs.webkit.org/attachment.cgi?id=357623&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 357623
--> https://bugs.webkit.org/attachment.cgi?id=357623
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357623&action=review
>> Source/JavaScriptCore/parser/Parser.cpp:3889
>> + failIfTrue(match(POW) &&
isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous
unary expression in the left hand side of the exponentiation expression;
parenthesis must be used to disambiguate the expression");
>
> Hmm, if we're fixing this string anyway, I suppose "parenthesis must be used"
-> "parentheses must be used" would be better too...
r=me with this change
More information about the webkit-reviews
mailing list