[webkit-reviews] review granted: [Bug 192833] String overflow in JSC::createError results in ASSERT in WTF::makeString : [Attachment 357625] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 192833: String overflow in JSC::createError results in ASSERT in
WTF::makeString
https://bugs.webkit.org/show_bug.cgi?id=192833

Attachment 357625: Patch

https://bugs.webkit.org/attachment.cgi?id=357625&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 357625
  --> https://bugs.webkit.org/attachment.cgi?id=357625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357625&action=review

r=me

> JSTests/stress/string-overflow-createError.js:3
> +bar = '2.3023e-320'
> +foo = bar.padEnd(2147483644, 1);
> +foo(true, 1).value;

Does this test throw an exception?  If so, don't you have to put it in a try
catch statement?