[webkit-reviews] review requested: [Bug 191475] [iOS] WebKit should handle shift state changes when using the software keyboard : [Attachment 357627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 16:04:08 PST 2018


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 191475: [iOS] WebKit should handle shift state changes when using the
software keyboard
https://bugs.webkit.org/show_bug.cgi?id=191475

Attachment 357627: Patch

https://bugs.webkit.org/attachment.cgi?id=357627&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Created attachment 357627

  --> https://bugs.webkit.org/attachment.cgi?id=357627&action=review

Patch

It is not possible to write a test for this change with our current
infrastructure without mocking more of the software keyboard or performing user
interface testing. I am open to ideas.


More information about the webkit-reviews mailing list