[webkit-reviews] review granted: [Bug 192810] REGRESSION: [iOS] API test TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure : [Attachment 357614] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 15:13:56 PST 2018


Alex Christensen <achristensen at apple.com> has granted David Quesada
<david_quesada at apple.com>'s request for review:
Bug 192810: REGRESSION: [iOS] API test
TestWebKitAPI._WKDownload.OriginatingWebView is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=192810

Attachment 357614: Patch

https://bugs.webkit.org/attachment.cgi?id=357614&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 357614
  --> https://bugs.webkit.org/attachment.cgi?id=357614
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357614&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:260
> +    WTF::callOnMainThread([retainedDownload = RetainPtr<_WKDownload> {
download }] {

[download = retainPtr(download)]


More information about the webkit-reviews mailing list