[webkit-reviews] review granted: [Bug 192298] Redeclaration of var over let/const/class should be a syntax error. : [Attachment 357488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 18 13:38:12 PST 2018


Keith Miller <keith_miller at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 192298: Redeclaration of var over let/const/class should be a syntax error.
https://bugs.webkit.org/show_bug.cgi?id=192298

Attachment 357488: Patch

https://bugs.webkit.org/attachment.cgi?id=357488&action=review




--- Comment #20 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 357488
  --> https://bugs.webkit.org/attachment.cgi?id=357488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357488&action=review

r=me.

> Source/JavaScriptCore/parser/Parser.h:1233
> +	       // FIXME: This exemption should not apply if the var declaration
is a for-of initializer.

Lol...


More information about the webkit-reviews mailing list