[webkit-reviews] review granted: [Bug 192817] [WebGPU] BindGroupLayout and Device::createBindGroupLayout : [Attachment 357597] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 18 12:47:50 PST 2018
Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 192817: [WebGPU] BindGroupLayout and Device::createBindGroupLayout
https://bugs.webkit.org/show_bug.cgi?id=192817
Attachment 357597: Patch
https://bugs.webkit.org/attachment.cgi?id=357597&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 357597
--> https://bugs.webkit.org/attachment.cgi?id=357597
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357597&action=review
> Source/WebCore/Modules/webgpu/WebGPUBindGroupLayout.cpp:41
> + UNUSED_PARAM(layout);
Remove this. You use the parameter.
> Source/WebCore/Modules/webgpu/WebGPUDevice.cpp:71
> + return layout ?
static_cast<RefPtr<WebGPUBindGroupLayout>>(WebGPUBindGroupLayout::create(layout
.releaseNonNull())) : nullptr;
Why do you have to cast? I think the compiler will handle this.
> Source/WebCore/platform/graphics/gpu/GPUBindGroupLayout.cpp:35
> + return adoptRef(new GPUBindGroupLayout(WTFMove(descriptor)));
So for now it will never fail to return a layout? But it will in the future,
hence the try name?
More information about the webkit-reviews
mailing list