[webkit-reviews] review granted: [Bug 192786] webkitpy: Ignore device type for test when using --force : [Attachment 357502] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 192786: webkitpy: Ignore device type for test when using --force
https://bugs.webkit.org/show_bug.cgi?id=192786

Attachment 357502: Patch

https://bugs.webkit.org/attachment.cgi?id=357502&action=review




--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 357502
  --> https://bugs.webkit.org/attachment.cgi?id=357502
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357502&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:245
> +	       help="Run all tests with PASS as expected result, even those
marked SKIP in the test list and run tests " + \
> +		    "on available devices, even if the device type does not
match (implies --skipped=ignore)"),

The wording of this text is confusing and I had to read it over a few times for
it to make sense to me. Maybe it would be clearer to write: "Run all tests with
PASS as expected result, even those marked SKIP in the test list or are
device-specific (implies --skipped=ignore)".