[webkit-reviews] review granted: [Bug 192695] [Win][Clang] Fix compilation warnings under Source/WebKit directory : [Attachment 357426] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192695: [Win][Clang] Fix compilation warnings under Source/WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=192695

Attachment 357426: Patch

https://bugs.webkit.org/attachment.cgi?id=357426&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 357426
  --> https://bugs.webkit.org/attachment.cgi?id=357426
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357426&action=review

r=me

> Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.h:48
> +    void showPopupMenu(const WebCore::IntRect&, WebCore::TextDirection,
double pageScaleFactor, const Vector<WebPopupItem>&, const
PlatformPopupMenuData&, int32_t selectedIndex) override;

final?

> Source/WebKit/WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h:50
> +    WebCore::ResourceError blockedError(const WebCore::ResourceRequest&)
const override;

final?