[webkit-reviews] review requested: [Bug 174816] [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI : [Attachment 357550] Patch

[bugzilla-daemon at webkit.org]

Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger at igalia.com> has asked  for review:
Bug 174816: [GTK][WPE] Need a function to convert internal URI to display
("pretty") URI
https://bugs.webkit.org/show_bug.cgi?id=174816

Attachment 357550: Patch

https://bugs.webkit.org/attachment.cgi?id=357550&action=review




--- Comment #114 from Ms2ger (he/him; ⌚ UTC+1/+2) <Ms2ger at igalia.com> ---
Created attachment 357550

  --> https://bugs.webkit.org/attachment.cgi?id=357550&action=review

Patch

The normalization is, AFAIK, a translation of the following code in ObjC:

    result = [result precomposedStringWithCanonicalMapping];

... which can't really work in GTK.

If you're interested in the individual changes, see
https://github.com/WebKit/webkit/compare/master...Ms2ger:userVisibleString?expa
nd=1