[webkit-reviews] review granted: [Bug 192800] Update CSS Properties and Values API to use new cycle fallback behaviour : [Attachment 357532] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 192800: Update CSS Properties and Values API to use new cycle fallback
behaviour
https://bugs.webkit.org/show_bug.cgi?id=192800

Attachment 357532: Patch

https://bugs.webkit.org/attachment.cgi?id=357532&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 357532
  --> https://bugs.webkit.org/attachment.cgi?id=357532
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357532&action=review

> Source/WebCore/css/CSSVariableReferenceValue.cpp:89
> +    if ((!property || property->isInvalid()) && fallbackReturn) {
> +	   result.appendVector(fallbackResult);
> +	   return fallbackReturn;
> +    }
> +
> +    if (!property || property->isInvalid())
> +	   return false;

More compactly:

if (!property || property->isInvalid()) {
    if (fallbackReturn)
	result.appendVector(fallbackResult);
    return fallbackReturn;
}

>
LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/regis
ter-property-syntax-parsing-expected.txt:28
> -PASS syntax:'<length-percentage>', initialValue:'calc(-11px + 10.4%)' is
valid 
> +FAIL syntax:'<length-percentage>', initialValue:'calc(-11px + 10.4%)' is
valid The given initial value does not parse for the given syntax.

Why do some of these go from PASS to FAIL? You could mention it in the
ChangeLog.