[webkit-reviews] review granted: [Bug 192772] Regression(r239182) SuspendedPage's process reuse for link navigation optimization sometimes broken : [Attachment 357479] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 23:51:02 PST 2018


Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 192772: Regression(r239182) SuspendedPage's process reuse for link
navigation optimization sometimes broken
https://bugs.webkit.org/show_bug.cgi?id=192772

Attachment 357479: Patch

https://bugs.webkit.org/attachment.cgi?id=357479&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 357479
  --> https://bugs.webkit.org/attachment.cgi?id=357479
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357479&action=review

> Source/WebKit/ChangeLog:16
> +	   Address the issue by keeping the SuspendedPageProxy alive even if
the WebPage fails to suspend.
> +	   When trying to reuse a SuspendedPageProxy, if the page failed to
suspend, reuse its process but
> +	   not the suspended page itself.

As you mentioned in the original bug, a separate process cache for domains
might be a nicer design. This will do though.


More information about the webkit-reviews mailing list