[webkit-reviews] review granted: [Bug 192795] Array unshift/shift should not race against the AI in the compiler thread. : [Attachment 357527] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 192795: Array unshift/shift should not race against the AI in the compiler
thread.
https://bugs.webkit.org/show_bug.cgi?id=192795

Attachment 357527: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=357527&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 357527
  --> https://bugs.webkit.org/attachment.cgi?id=357527
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=357527&action=review

> Source/JavaScriptCore/ChangeLog:16
> +	   operations can move values around in the butterfly.	Hence, the fact
that AI has

Do any operations do this without grabbing the lock? Or does this kind of
moving around require holding the lock?