[webkit-reviews] review requested: [Bug 192788] Wrong value for key property in keydown and keyup events generated holding Control key : [Attachment 357504] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 17 17:02:44 PST 2018
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 192788: Wrong value for key property in keydown and keyup events generated
holding Control key
https://bugs.webkit.org/show_bug.cgi?id=192788
Attachment 357504: Patch
https://bugs.webkit.org/attachment.cgi?id=357504&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 357504
--> https://bugs.webkit.org/attachment.cgi?id=357504&action=review
Patch
I did not include a test with this change as the patch uses the same code as we
do on Mac, we do currently have infrastructure to generate a key event with a
Control key modifier flag that has different unmodified and modified input
strings, and I wanted to post this patch sooner. When I have a moment I will
look to add testing support.
More information about the webkit-reviews
mailing list