[webkit-reviews] review granted: [Bug 192770] Fix stale assertion in attemptToForceStringArrayModeByToStringConversion(). : [Attachment 357466] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 12:52:12 PST 2018


Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 192770: Fix stale assertion in
attemptToForceStringArrayModeByToStringConversion().
https://bugs.webkit.org/show_bug.cgi?id=192770

Attachment 357466: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=357466&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 357466
  --> https://bugs.webkit.org/attachment.cgi?id=357466
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=357466&action=review

r=me.

> JSTests/ChangeLog:9
> +	   * stress/regress-192770.js: Added.

Nit: Can we give this a real name? I kinda hate the "regress-<unclear
number>.js" convention.


More information about the webkit-reviews mailing list