[webkit-reviews] review granted: [Bug 192714] Unify SharedMemory factory functions : [Attachment 357418] Patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 16 11:13:56 PST 2018

Darin Adler <darin at apple.com> has granted Adrian Perez <aperez at igalia.com>'s
request for review:
Bug 192714: Unify SharedMemory factory functions

Attachment 357418: Patch v3


--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 357418
  --> https://bugs.webkit.org/attachment.cgi?id=357418
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=357418&action=review

> Source/WebKit/Platform/win/SharedMemoryWin.cpp:135
> +    HANDLE handle = ::CreateFileMappingW(INVALID_HANDLE_VALUE, 0,
protectAttribute(SharedMemory::Protection::ReadWrite), 0, size, 0);

Similar comment to the one I made earlier for the Unix code. This should say
PAGE_READWRITE, not protectAttribute(SharedMemory::Protection::ReadWrite).

More information about the webkit-reviews mailing list