[webkit-reviews] review granted: [Bug 192743] Use warning-ignoring macros more consistently and simply : [Attachment 357405] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 15 16:04:17 PST 2018
Mark Lam <mark.lam at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 192743: Use warning-ignoring macros more consistently and simply
https://bugs.webkit.org/show_bug.cgi?id=192743
Attachment 357405: Patch
https://bugs.webkit.org/attachment.cgi?id=357405&action=review
--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 357405
--> https://bugs.webkit.org/attachment.cgi?id=357405
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=357405&action=review
r=me
> Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h:35
> + explicit WebAlternativeTextClient(WebView *);
Remove space between "WebView" and "*".
> Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.h:54
> + WebView *m_webView;
Shouldn't this be "WebView* m_webView;"? Why move the placement of the space?
More information about the webkit-reviews
mailing list