[webkit-reviews] review canceled: [Bug 192728] wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from : [Attachment 357360] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 14 17:15:37 PST 2018


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 192728: wtf/Optional.h: move-constructor and move-assignment operator
should disengage the value being moved from
https://bugs.webkit.org/show_bug.cgi?id=192728

Attachment 357360: Patch v1

https://bugs.webkit.org/attachment.cgi?id=357360&action=review




--- Comment #6 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 357360
  --> https://bugs.webkit.org/attachment.cgi?id=357360
Patch v1

1. Totally untested (still building locally).
2. Tests may break if the libc++ implementation is used instead of
<wtf/Optional.h>.


More information about the webkit-reviews mailing list