[webkit-reviews] review granted: [Bug 192724] Web Inspector: Avoid creating and evaluating in the InspectorOverlay page on iOS as it is unused : [Attachment 357354] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 14 16:36:43 PST 2018


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 192724: Web Inspector: Avoid creating and evaluating in the
InspectorOverlay page on iOS as it is unused
https://bugs.webkit.org/show_bug.cgi?id=192724

Attachment 357354: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=357354&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 357354
  --> https://bugs.webkit.org/attachment.cgi?id=357354
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=357354&action=review

rs=me, good catch!

> Source/WebCore/inspector/InspectorOverlay.cpp:183
> +    Page* overlayPage = this->overlayPage();

Is this actually reachable on iOS?  I'd expect `InspectorOverlay::paint` (which
is called from `InspectorController::drawHighlight`, which is called from
`WebInspectorClient::drawRect`) to not happen on iOS, since it doesn't actually
involve creating a `PageOverlay`?


More information about the webkit-reviews mailing list