[webkit-reviews] review granted: [Bug 192693] [Win][Clang] Fix compilation warnings under Source/WebCore/platform/win : [Attachment 357299] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 192693: [Win][Clang] Fix compilation warnings under
Source/WebCore/platform/win
https://bugs.webkit.org/show_bug.cgi?id=192693

Attachment 357299: Patch

https://bugs.webkit.org/attachment.cgi?id=357299&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 357299
  --> https://bugs.webkit.org/attachment.cgi?id=357299
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357299&action=review

> Source/WebCore/ChangeLog:31
> +	   (WebCore::osVersionForUAString): Added defalut case.

Nit: "default"

> Source/WebCore/platform/win/PopupMenuWin.cpp:612
> -    // listRect is the damageRect translated into the coordinates of the
entire menu list (which is itemCount * m_itemHeight pixels tall)
> +    // listRect is the damageRect translated into the coordinates of the
entire menu list (which is itemSize * m_itemHeight pixels tall)

Did you mean "listSize"? I don't see an "itemSize"...