[webkit-reviews] review granted: [Bug 192640] Make HTMLConverter work across shadow boundaries : [Attachment 357208] Fixes the bug

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 192640: Make HTMLConverter work across shadow boundaries
https://bugs.webkit.org/show_bug.cgi?id=192640

Attachment 357208: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=357208&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 357208
  --> https://bugs.webkit.org/attachment.cgi?id=357208
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=357208&action=review

r=me, with test fixes!

> Source/WebCore/dom/Position.cpp:1606
> +    TreeScope* commonScope = commonTreeScope(a.containerNode(),
b.containerNode());

Nit - auto*?

> Source/WebCore/editing/cocoa/HTMLConverter.mm:2321
> +		       Node* child =
firstChildInComposedTreeIgnoringUserAgentShadow(node);

Nit - auto*?

> Source/WebCore/editing/cocoa/HTMLConverter.mm:2368
> +	       Node* child =
firstChildInComposedTreeIgnoringUserAgentShadow(element);

Nit - auto*?

>
LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-bound
aries-with-style-1.html:12
> +    dumpAttributedString(container, source, 0, shadowRoot.lastChild,
shadowRoot.lastChild.data.indexOf('Kit'));

What is `source` here?

>
LayoutTests/editing/mac/attributed-string/attributed-string-across-shadow-bound
aries-with-style-2.html:15
> +    dumpAttributedString(container, source, 0,
shadowRoot2.querySelector('u'), 1);

Here too?